Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up a number of style/lint issues ahead of further changes #28

Merged
merged 8 commits into from
May 22, 2024

Conversation

dpup
Copy link
Owner

@dpup dpup commented May 21, 2024

Please review the following commits I made in branch dan/multiple-files:

cb485f8 (2024-05-21 16:58:45 -0700)
Add stricter lint config and fix a number of issues

e550a8c (2024-05-21 16:07:20 -0700)
Embed Options inside Registry to remove duplicated defs

09fdc81 (2024-05-21 15:54:30 -0700)
Rename template related methods and fields

14fe8c1 (2024-05-21 15:45:59 -0700)
Introduce explicit template payload

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@dpup dpup changed the title Add stricter lint config and fix a number of issues Cleans up a number of style/lint issues ahead of further changes May 21, 2024
@dpup dpup merged commit 4a3d7af into main May 22, 2024
2 checks passed
@dpup dpup deleted the dan/multiple-files branch May 22, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant